Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings to customize the progress bar #507

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

callms
Copy link

@callms callms commented Mar 16, 2024

Add settings to:

Reverse how the progress bar fills

xdripswift 5.0 added a new progress bar at the bottom of the home screen to show how much time the sensor will still be active. By default, the progress bar “fills” up to the last day, this is opposite to how some apps (FL/FL2/FL3) work which might confuse users. Also for some reasons I find it more intuitive that the progress bar “empties”, like a battery indicator, and becomes “exhausted” when the sensor ends.

before after
IMG_7156 IMG_7155

Opt-out to the progress animation

When switching betweentabs, by defaults, the progress bar animates from zero. This PR adds a toggle to opt-out.

Settings Screen

Here is a screen showing how the settings screen shows with these two options:

IMG_7157

@paulplant paulplant changed the base branch from master to develop May 31, 2024 06:33
@paulplant
Copy link
Collaborator

Hi @callms , I was looking at this. I don't think we need to copy how Abbott do the sensor countdown for any real reason, but I can understand how some people might prefer to "count down" available sensor instead of "use up" the remaining sensor. The only thing for me was that it could be very confusing which option the user was using. Adding the text change to the used vs remaining in the later commit I think fixes this concern...

But, I'm not sure that adding an opt-out of the animation really adds much value. We've been actively reducing Settings options and will continue to hide/remove low-value settings over the next months.

I can see how the "count down" setting works and is needed, but I don't think we can justify an "no animation" setting.

Do you agree? Also the settings have changed a lot since you wrote the PR so we'd need to adjust things to fit.

@callms callms force-pushed the feat/progress-bar-settings branch from 2914a3d to 1281664 Compare June 8, 2024 07:09
@callms callms force-pushed the feat/progress-bar-settings branch from a35c6c5 to 65283df Compare September 24, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants